-
Notifications
You must be signed in to change notification settings - Fork 123
Centralize layout configuration in single constants file #4431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Introduce ACTIVE_* constants to provide a single source of truth for customizing application layout, header, login page, and footer components. This allows users to change layout configuration by modifying only the Active Layout Configuration section in constant.ts.
WalkthroughReplaces literal layout and direct configuration identifiers with centralized constants exported from Changes
Sequence Diagram(s)(omitted — changes are configuration/constant centralization and do not introduce a new multi-component sequential flow) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@shesha-reactjs/src/components/mainLayout/constant.ts`:
- Around line 18-41: Add explicit type annotations for the exported constants
ACTIVE_HEADER, ACTIVE_LOGIN, and ACTIVE_FOOTER (similar to LAYOUT_MODE's
LayoutMode annotation) to improve clarity and type safety; update the
declarations for ACTIVE_HEADER, ACTIVE_LOGIN, and ACTIVE_FOOTER to include their
respective types (e.g., HeaderConfigType, LoginConfigType, FooterConfigType or
the actual types used for HEADER_CONFIGURATION, LOGIN_CONFIGURATION,
FOOTER_CONFIGURATION) so the compiler and readers can see the intended types
directly on ACTIVE_HEADER, ACTIVE_LOGIN, and ACTIVE_FOOTER.
Introduce ACTIVE_* constants to provide a single source of truth for customizing application layout, header, login page, and footer components. This allows users to change layout configuration by modifying only the Active Layout Configuration section in constant.ts.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.