-
Notifications
You must be signed in to change notification settings - Fork 123
Fix datatable auto config for columns #4459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis PR adds repository-type awareness to data table components by gating column loading, validation, and registration logic based on whether the data source is an entity. The changes introduce conditional checks across multiple designer components and utility functions to selectively apply auto-configuration and validation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~23 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
shesha-reactjs/src/designer-components/dataTable/table/columnsEditor/columnsEditorModal.tsx (1)
18-18: Avoidanytype; use a specific function signature.The
onChangeprop is typed asany, which violates the coding guideline to eliminate theanytype. Use a proper function type instead.♻️ Suggested fix
- onChange?: any; + onChange?: (columns: ColumnsItemProps[]) => void;As per coding guidelines, eliminate the
anytype and use explicit type definitions.
#3516 (comment)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.