Skip to content

Update form configs for cs-form-create, form-templates#4589

Merged
IvanIlyichev merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlumise/forms
Mar 11, 2026
Merged

Update form configs for cs-form-create, form-templates#4589
IvanIlyichev merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlumise/forms

Conversation

@Lihlu
Copy link
Copy Markdown
Collaborator

@Lihlu Lihlu commented Mar 11, 2026

Summary by CodeRabbit

  • Chores
    • Internal configuration update to the project build system.

Co-Authored-By: KatlehoMadaba <101579604+KatlehoMadaba@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 250a8e74-5342-435f-98f2-6b2d33a7cfeb

📥 Commits

Reviewing files that changed from the base of the PR and between 9477a08 and ff497d8.

📒 Files selected for processing (2)
  • shesha-core/src/Shesha.Application/ConfigMigrations/package20260311_1518.shaconfig
  • shesha-core/src/Shesha.Application/Shesha.Application.csproj

Walkthrough

A configuration migration file (package20260311_1518.shaconfig) is transitioned from a non-embedded resource to an embedded resource in the Shesha.Application project file, changing how the file is compiled and packaged.

Changes

Cohort / File(s) Summary
Project Resource Configuration
shesha-core/src/Shesha.Application/Shesha.Application.csproj
Configuration migration file moved from None/Remove to EmbeddedResource/Include status, changing resource embedding behavior during compilation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • IvanIlyichev
  • AlexStepantsov

Poem

🐰 A config file tucked so tight,
Embedded now, bundled just right,
From loose and free to nestled deep,
In resources where migrations sleep! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions updating form configs for specific forms, but the actual change is embedding a configuration file in the project. The title does not accurately describe the main technical change. Revise the title to reflect the actual change, such as 'Embed form configuration file as resource' or similar, to better describe the ConfigMigrations package transition.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lihlu Lihlu marked this pull request as ready for review March 11, 2026 13:34
@Lihlu Lihlu requested a review from IvanIlyichev March 11, 2026 13:53
@IvanIlyichev IvanIlyichev merged commit b2d97cd into shesha-io:main Mar 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants