Skip to content

Thulasizwe/bug/4607#4632

Merged
James-Baloyi merged 4 commits intoshesha-io:mainfrom
czwe-01:thulasizwe/bug/4607
Mar 18, 2026
Merged

Thulasizwe/bug/4607#4632
James-Baloyi merged 4 commits intoshesha-io:mainfrom
czwe-01:thulasizwe/bug/4607

Conversation

@czwe-01
Copy link
Copy Markdown
Collaborator

@czwe-01 czwe-01 commented Mar 18, 2026

#4607

Summary by CodeRabbit

Bug Fixes

  • Fixed label display in button group configurator
  • Improved form item label sizing and tooltip alignment across form layouts
  • Enhanced HTTP verb resolution in endpoint autocomplete based on form context

Style Improvements

  • Optimized form item label height handling for consistent visual rendering

Minor Updates

  • Updated API Call action label for improved clarity

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 18, 2026

Warning

Rate limit exceeded

@czwe-01 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fee1ff46-001b-4c8f-99f9-604d286d9e17

📥 Commits

Reviewing files that changed from the base of the PR and between 2e10be7 and 4e5efcb.

📒 Files selected for processing (2)
  • shesha-reactjs/src/components/endpointsAutocomplete/endpointsAutocomplete.tsx
  • shesha-reactjs/src/designer-components/endpointsAutocomplete/endpointsAutocomplete.tsx

Walkthrough

This PR adjusts form label visibility settings, updates CSS styling for form labels and associated tooltips, modifies HTTP verb evaluation logic in endpoints autocomplete components across different architectural layers, and updates an action configuration label from "Call API" to "API Call".

Changes

Cohort / File(s) Summary
Form Label Configuration & Styling
src/components/buttonGroupConfigurator/itemSettings.ts, src/components/mainLayout/styles/indexStyles.ts, src/designer-components/_settings/styles/styles.ts
Removed hideLabel setting on Action Configuration, and added CSS rules to set form-item labels to height: auto !important, with additional tooltip positioning adjustments (align-self: end, relative position, top offset).
Endpoints Autocomplete HTTP Verb Handling
src/components/endpointsAutocomplete/endpointsAutocomplete.tsx, src/designer-components/endpointsAutocomplete/endpointsAutocomplete.tsx
Component layer adds dynamic HTTP verb evaluation using form data and evaluateValueAsString for URL-mode fetches; designer layer removes this dynamic evaluation, simplifying to direct model.httpVerb usage.
Action Configuration Label
src/providers/sheshaApplication/configurable-actions/api-call.ts
Updated exported action label from "Call API" to "API Call".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A label breaks free from its hidden chains,
Verbs flow through form data like spring rains,
CSS paints tooltips with pixel precision,
API calls now shine with clearer vision! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Thulasizwe/bug/4607' is a branch name rather than a descriptive PR title. It does not convey any meaningful information about the actual changes made in the pull request. Rename the title to clearly describe the primary change, such as 'Fix form item heights and simplify endpoint verb handling' or reference issue #4607 with a descriptive summary.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@shesha-reactjs/src/components/endpointsAutocomplete/endpointsAutocomplete.tsx`:
- Around line 87-89: The evaluated verb (const verb = ...
evaluateValueAsString(...)) can be unresolved and you must guard any
autocomplete/fetch logic against that; update places that trigger network calls
(the autocomplete/fetch code that uses verb — e.g., the function that builds
requests or the useEffect that fires suggestions) to first verify verb is a
resolved non-empty string (e.g., typeof verb === 'string' && verb.trim() !== ''
and/or not a sentinel "UNRESOLVED" value) and return/skip the fetch when it's
not valid; ensure the same guard is applied wherever verb is read (including the
code paths around props.httpVerb evaluation and the fetch/suggestions code
referenced by verb) so no request is made with an unresolved value.

In
`@shesha-reactjs/src/designer-components/endpointsAutocomplete/endpointsAutocomplete.tsx`:
- Line 27: The EndpointsAutocomplete component call redundantly passes
httpVerb={model?.httpVerb} while already spreading {...model}; remove the
duplicate prop to avoid shadowing and confusion—update the JSX in the
EndpointsAutocomplete invocation to omit the explicit httpVerb prop and rely on
the spread (keep existing value={value} and onChange={onChange} as-is).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1315e927-3f1b-48e1-92df-643f9de57d66

📥 Commits

Reviewing files that changed from the base of the PR and between 22a6d98 and 2e10be7.

📒 Files selected for processing (6)
  • shesha-reactjs/src/components/buttonGroupConfigurator/itemSettings.ts
  • shesha-reactjs/src/components/endpointsAutocomplete/endpointsAutocomplete.tsx
  • shesha-reactjs/src/components/mainLayout/styles/indexStyles.ts
  • shesha-reactjs/src/designer-components/_settings/styles/styles.ts
  • shesha-reactjs/src/designer-components/endpointsAutocomplete/endpointsAutocomplete.tsx
  • shesha-reactjs/src/providers/sheshaApplication/configurable-actions/api-call.ts
💤 Files with no reviewable changes (1)
  • shesha-reactjs/src/components/buttonGroupConfigurator/itemSettings.ts

@czwe-01 czwe-01 requested a review from James-Baloyi March 18, 2026 07:32
@James-Baloyi James-Baloyi merged commit a87d6ae into shesha-io:main Mar 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants