Skip to content

security: let database permissions override code-level AllowAnonymous #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktsapo wants to merge 1 commit into
base: releases/0.43
Choose a base branch
from
Open

security: let database permissions override code-level AllowAnonymous #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions shesha-core/src/Shesha.Application/Authorization/ApiAuthorizationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
using Shesha.Configuration.Security;
using Shesha.Domain.Enums;
using Shesha.Extensions;
using Shesha.Permissions;
using Shesha.Reflection;
Expand Down Expand Up @@ -44,9 +45,8 @@ public override async Task AuthorizeAsync(MethodInfo methodInfo, Type type)
return;
}

if (type.HasAttribute<AllowAnonymousAttribute>() || methodInfo.HasAttribute<AllowAnonymousAttribute>()
|| type.HasAttribute<AbpAllowAnonymousAttribute>() || methodInfo.HasAttribute<AbpAllowAnonymousAttribute>())
return;
var hasCodeAllowAnonymous = type.HasAttribute<AllowAnonymousAttribute>() || methodInfo.HasAttribute<AllowAnonymousAttribute>()
|| type.HasAttribute<AbpAllowAnonymousAttribute>() || methodInfo.HasAttribute<AbpAllowAnonymousAttribute>();

var shaServiceType = typeof(ApplicationService);
var controllerType = typeof(ControllerBase);
Expand All @@ -61,19 +61,25 @@ public override async Task AuthorizeAsync(MethodInfo methodInfo, Type type)
return;

var securitySettings = await _securitySettings?.SecuritySettings?.GetValueAsync();
var settings = securitySettings?.DefaultEndpointAccess;
var defaultAccess = securitySettings?.DefaultEndpointAccess;

if (settings == null)
if (defaultAccess == null)
throw new NullReferenceException("Cannot get DefaultEndpointAccess");

// ToDo: add RequireAll flag
// If code-level [AllowAnonymous] is present, use it as the fallback for Inherited.
// Database configuration with an explicit access level will still take precedence.
var replaceInherited = hasCodeAllowAnonymous
? RefListPermissionedAccess.AllowAnonymous
: defaultAccess;

// Note: requireAll is intentionally false — multiple permissions are OR'd (any single permission grants access)
await _objectPermissionChecker.AuthorizeAsync(
false,
typeName,
methodName,
ShaPermissionedObjectsTypes.WebApiAction,
AbpSession.UserId.HasValue,
settings
replaceInherited
);
}
}
Expand Down
8 changes: 0 additions & 8 deletions shesha-core/src/Shesha.Application/Authorization/SheshaAuthorizationFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
using Abp.Events.Bus.Exceptions;
using Abp.Web.Models;
using Castle.Core.Logging;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Mvc.Filters;
Expand Down Expand Up @@ -39,13 +38,6 @@ public SheshaAuthorizationFilter(

public virtual async Task OnAuthorizationAsync(AuthorizationFilterContext context)
{
var endpoint = context?.HttpContext?.GetEndpoint();
// Allow Anonymous skips all authorization
if (endpoint?.Metadata.GetMetadata<IAllowAnonymous>() != null)
{
return;
}

if (!context.ActionDescriptor.IsControllerAction())
{
return;
Expand Down