Skip to content

Restore striped rows and row dividers on entity picker modal table#4650

Merged
James-Baloyi merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlumise/b/entity-picker-striped-rows
Mar 19, 2026
Merged

Restore striped rows and row dividers on entity picker modal table#4650
James-Baloyi merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlumise/b/entity-picker-striped-rows

Conversation

@Lihlu
Copy link
Collaborator

@Lihlu Lihlu commented Mar 18, 2026

#4661

Summary by CodeRabbit

  • Style
    • Enhanced DataTable styling with alternate row backgrounds and dividers for improved readability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e4ced5c9-ec0e-4ad9-bbce-b74d642094a8

📥 Commits

Reviewing files that changed from the base of the PR and between a87d6ae and 68d37e3.

📒 Files selected for processing (1)
  • shesha-reactjs/src/components/entityPicker/modal.tsx

Walkthrough

A single file modification that imports getTableDefaults and passes styling properties (striped, rowDividers, rowAlternateBackgroundColor) to the DataTable component in the entity picker modal, enabling default table styling without changing data or logic.

Changes

Cohort / File(s) Summary
Entity Picker Styling
shesha-reactjs/src/components/entityPicker/modal.tsx
Import getTableDefaults and apply returned styling properties to DataTable component for alternate row background colors, row dividers, and striped formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 With striped rows and dividers so fine,
The table now dances in DataTable's design,
Default styling applied without a care,
Modal's appearance gets a gentle flare!
No logic was harmed in this styling affair,
Just prettier tables everywhere! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: restoring striped rows and row dividers styling to the entity picker modal table.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lihlu Lihlu marked this pull request as ready for review March 19, 2026 10:45
@Lihlu Lihlu requested a review from James-Baloyi March 19, 2026 11:01
@James-Baloyi James-Baloyi merged commit 55665d8 into shesha-io:main Mar 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants