Skip to content

Fix enitity picker modal styling#4670

Merged
James-Baloyi merged 2 commits intoshesha-io:mainfrom
Lihlu:lihlumise/b/4661
Mar 20, 2026
Merged

Fix enitity picker modal styling#4670
James-Baloyi merged 2 commits intoshesha-io:mainfrom
Lihlu:lihlumise/b/4661

Conversation

@Lihlu
Copy link
Collaborator

@Lihlu Lihlu commented Mar 20, 2026

#4661

Summary by CodeRabbit

Release Notes

  • Style
    • Enhanced entity picker modal styling with improved header presentation, including consistent color, font sizing, and weight across table headers.
    • Refined table container layout with more deterministic styling rules and adjusted modal footer spacing for better visual consistency.

Lihlu added 2 commits March 20, 2026 08:45
  - Apply white header background and font defaults to match configured tables
  - Add outside border and border-radius to the table container
  - Fix table width alignment with search bar and filter elements
  - Fix modal footer padding causing Close button misalignment
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5bab36e4-f80f-4c65-8c40-857232650787

📥 Commits

Reviewing files that changed from the base of the PR and between 552546b and eee7bc8.

📒 Files selected for processing (2)
  • shesha-reactjs/src/components/entityPicker/modal.tsx
  • shesha-reactjs/src/components/entityPicker/styles/styles.ts

Walkthrough

The entity picker modal's DataTable component now receives explicit header styling properties sourced from getTableDefaults(), and CSS rules for table and modal footer containers have been refined with !important overrides and additional layout framing to ensure consistent visual presentation.

Changes

Cohort / File(s) Summary
Entity Picker Modal Styling
shesha-reactjs/src/components/entityPicker/modal.tsx, shesha-reactjs/src/components/entityPicker/styles/styles.ts
Header presentation props (headerBackgroundColor, headerFontSize, headerFontWeight, headerFontFamily) added to DataTable. Table styling enhanced with !important overrides for margin and width, block display mode, and explicit container framing (border, border-radius, box-sizing). Modal footer padding adjusted for consistency.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A table now grooms with header so fair,
With colors and fonts with utmost care,
The modal's frame holds steady and true,
Styling refined to make all anew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title contains a typo ('enitity' instead of 'entity') and accurately describes the main changes to entity picker modal styling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lihlu Lihlu requested a review from James-Baloyi March 20, 2026 07:08
@Lihlu Lihlu marked this pull request as ready for review March 20, 2026 07:08
@James-Baloyi James-Baloyi merged commit 94e2478 into shesha-io:main Mar 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants