Skip to content

Update Header form#4675

Merged
IvanIlyichev merged 2 commits intoshesha-io:mainfrom
Lihlu:lihlumise/f/header-form
Mar 23, 2026
Merged

Update Header form#4675
IvanIlyichev merged 2 commits intoshesha-io:mainfrom
Lihlu:lihlumise/f/header-form

Conversation

@Lihlu
Copy link
Collaborator

@Lihlu Lihlu commented Mar 23, 2026

Summary by CodeRabbit

  • Chores
    • Updated build configuration so a configuration file is embedded into the application assembly.
    • Ensured the embedded configuration file is not copied to the build output directory.

Co-authored-by: KatlehoMadaba <KatlehoMadaba@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8a378fc4-371d-44b8-9f21-859d85865aab

📥 Commits

Reviewing files that changed from the base of the PR and between 5c143de and 98aa6ab.

📒 Files selected for processing (1)
  • shesha-core/src/Shesha.Application/Shesha.Application.csproj

Walkthrough

ConfigMigrations\package20260323_1136.shaconfig was moved from a None project item to EmbeddedResource in the project file and marked with CopyToOutputDirectory set to Never, changing it to an embedded assembly resource not copied to build output.

Changes

Cohort / File(s) Summary
Embedded resource metadata
shesha-core/src/Shesha.Application/Shesha.Application.csproj
Removed ConfigMigrations\package20260323_1136.shaconfig from None and added it as EmbeddedResource with <CopyToOutputDirectory>Never</CopyToOutputDirectory>, embedding the migration package and preventing output copying.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 I tucked a package safe inside,
No extra file to roam or hide,
Embedded snug within the build,
Quiet, steady, calm and stilled,
A hoppity cheer for changes applied.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title 'Update Header form' does not accurately reflect the actual changes in the changeset. The changes involve configuring a migration configuration file as an embedded resource in the C# project, which is unrelated to updating a header form. Update the pull request title to accurately describe the actual change, such as 'Embed ConfigMigrations package configuration as resource' or similar to reflect the project file modification.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@shesha-core/src/Shesha.Application/Shesha.Application.csproj`:
- Around line 157-159: Remove the extra CopyToOutputDirectory directive from the
EmbeddedResource entry for "ConfigMigrations\package20260323_1136.shaconfig" so
it matches the other migration package entries; specifically edit the
<EmbeddedResource Include="ConfigMigrations\package20260323_1136.shaconfig">
block in Shesha.Application.csproj to use the simple self-closing form
(<EmbeddedResource Include="..."/>), leaving the resource embedded only (no
<CopyToOutputDirectory>), since EmbeddedPackageSeeder reads resources via
Assembly.GetManifestResourceNames() and GetEmbeddedResourceStream().

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: fecdc6cb-6a07-417c-9757-5a8c75574cc1

📥 Commits

Reviewing files that changed from the base of the PR and between 94e2478 and 5c143de.

📒 Files selected for processing (2)
  • shesha-core/src/Shesha.Application/ConfigMigrations/package20260323_1136.shaconfig
  • shesha-core/src/Shesha.Application/Shesha.Application.csproj

@Lihlu Lihlu requested a review from IvanIlyichev March 23, 2026 10:47
@IvanIlyichev IvanIlyichev merged commit d23ea09 into shesha-io:main Mar 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants