Skip to content

Update login, cs-form-create, and details-view forms#4685

Merged
IvanIlyichev merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlumise/f/update-framework-forms
Mar 24, 2026
Merged

Update login, cs-form-create, and details-view forms#4685
IvanIlyichev merged 1 commit intoshesha-io:mainfrom
Lihlu:lihlumise/f/update-framework-forms

Conversation

@Lihlu
Copy link
Collaborator

@Lihlu Lihlu commented Mar 24, 2026

Summary by CodeRabbit

  • Chores
    • Updated build configuration to properly embed configuration migration artifacts in the application package.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 68d31928-6bf6-4bd2-aeab-64a9131d6d1b

📥 Commits

Reviewing files that changed from the base of the PR and between edd2145 and b902a57.

📒 Files selected for processing (2)
  • shesha-core/src/Shesha.Application/ConfigMigrations/package20260324_1606.shaconfig
  • shesha-core/src/Shesha.Application/Shesha.Application.csproj

Walkthrough

A configuration migration artifact (ConfigMigrations\package20260324_1606.shaconfig) is migrated from being excluded from the project to being embedded as a resource in the compiled assembly.

Changes

Cohort / File(s) Summary
Project Configuration
shesha-core/src/Shesha.Application/Shesha.Application.csproj
Removed file from None items and added it as an EmbeddedResource, changing how the configuration migration artifact is handled during the build process.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A config so nested, was once set free,
Now bundled within, where it's meant to be,
No copies to scatter, just embedded so tight,
The migration hops forward, everything's right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The pull request title mentions updating forms (login, cs-form-create, details-view), but the actual changeset only modifies a .csproj file to embed a configuration migration artifact. Update the title to accurately reflect the actual changes, such as 'Embed configuration migration artifact ConfigMigrations/package20260324_1606.shaconfig' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Lihlu Lihlu marked this pull request as ready for review March 24, 2026 14:28
@Lihlu Lihlu requested a review from IvanIlyichev March 24, 2026 14:28
@IvanIlyichev IvanIlyichev merged commit c75ef5f into shesha-io:main Mar 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants