Skip to content

Add cors, fixed graphql playground registration and security headers … #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ktsapo wants to merge 1 commit into
base: releases/0.43
Choose a base branch
from
Open

Add cors, fixed graphql playground registration and security headers … #4712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shesha-core/src/Shesha.Web.Host/Startup/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public void Configure(IApplicationBuilder app, IBackgroundJobClient backgroundJo
});

app.UseMiddleware<GraphQLMiddleware>();
if (_hostEnvironment.IsDevelopment())
if (!_hostEnvironment.IsProduction())
{
app.UseGraphQLPlayground(); //to explorer API navigate https://*DOMAIN*/ui/playground
}
Expand Down
2 changes: 0 additions & 2 deletions ...-tests/backend/src/Boxfusion.SheshaFunctionalTests.Web.Host/Controllers/HomeController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using System;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Mvc;
Expand All @@ -10,7 +9,6 @@ namespace Boxfusion.SheshaFunctionalTests.Web.Host.Controllers
[AllowAnonymous]
public class HomeController : SheshaControllerBase
{

private readonly ISecuritySettings _securitySettings;

public HomeController(ISecuritySettings securitySettings)
Expand Down
23 changes: 18 additions & 5 deletions ...-functional-tests/backend/src/Boxfusion.SheshaFunctionalTests.Web.Host/Startup/Startup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
using Swashbuckle.AspNetCore.SwaggerGen;
using System;
using System.IO;
using System.Linq;
using System.Reflection;
using Microsoft.Extensions.Hosting;
using Shesha.Specifications;

namespace Boxfusion.SheshaFunctionalTests.Web.Host.Startup
Expand Down Expand Up @@ -156,11 +158,21 @@ public void Configure(IApplicationBuilder app, IBackgroundJobClient backgroundJo
options.UseAbpRequestLocalization = false;
});

// Security headers
app.UseSecurityHeaders();

// global cors policy
var corsOrigins = _appConfiguration["App:CorsOrigins"]?
.Split(",", StringSplitOptions.RemoveEmptyEntries)
.Select(o => o.Trim().TrimEnd('/'))
.Where(o => !string.IsNullOrEmpty(o))
.ToArray() ?? Array.Empty<string>();
app.UseCors(x => x
.AllowAnyMethod()
.AllowAnyHeader()
.SetIsOriginAllowed(origin => true) // allow any origin
.AllowCredentials()); // allow credentials​
.WithOrigins(corsOrigins)
.AllowCredentials());

app.UseStaticFiles();
app.UseAuthentication();
app.UseAbpRequestLocalization();
Expand Down Expand Up @@ -198,15 +210,16 @@ public void Configure(IApplicationBuilder app, IBackgroundJobClient backgroundJo
.GetManifestResourceStream("Boxfusion.SheshaFunctionalTests.Web.Host.wwwroot.swagger.ui.index.html");
}); // URL: /swagger​



app.UseHangfireDashboard("/hangfire",
new DashboardOptions
{
Authorization = new[] { new HangfireAuthorizationFilter() }
});
app.UseMiddleware<GraphQLMiddleware>();
app.UseGraphQLPlayground(); //to explorer API navigate https://*DOMAIN*/ui/playground
if (!_hostEnvironment.IsProduction())
{
app.UseGraphQLPlayground(); //to explorer API navigate https://*DOMAIN*/ui/playground
}
}

private void AddApiVersioning(IServiceCollection services)
Expand Down