azure private dns txt needs ttl #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR addresses a 400 error encountered during Azure private DNS TXT record creation by setting a default TTL value.
- Adds a default TTL of 3600 seconds when creating the TXT record data.
Reviewed Changes
| File | Description |
|---|---|
| KeyVault.Acmebot/Providers/AzurePrivateDnsProvider.cs | Sets a default TTL value to fix the 400 error during TXT record creation |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
KeyVault.Acmebot/Providers/AzurePrivateDnsProvider.cs:48
- [nitpick] Consider using a named constant for the default TTL value (e.g. DEFAULT_TTL) to improve clarity and maintainability.
var txtRecordData = new PrivateDnsTxtRecordData() { TtlInSeconds = 3600 };
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure private DNS TXT record creation is returning a 400. After debugging, I've deduced that it is because no TTL is being provided. This commit introduces a default TTL of 3600 seconds.