Move glyph interpolation into shift-font - #152
Merged
Merged
Conversation
kostyafarber
commented
Jul 16, 2026
| preferred_layer_for_glyph(glyph) | ||
| } | ||
|
|
||
| fn locations_equal(left: &Location, right: &Location, font: &Font) -> bool { |
Collaborator
Author
There was a problem hiding this comment.
should we make location impl equality? instead or use traits
kostyafarber
marked this pull request as ready for review
July 16, 2026 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shift-fontFontProjectionandResolvedGlyphas a location-bound read-only projection with exact-source, interpolation, sparse fallback, and recursive component semanticsshift-wireto adapting native interpolation into renderer DTOs, and remove the leakedGlyphMasterNAPI/TypeScript contractWhy
Issue #150 needs a lightweight batch preview built on a canonical Rust projection. Previously, interpolation semantics and flattened glyph values were partly owned by
shift-wire, which made a preview resolver either duplicate that logic or turn a transport crate into a domain service.This PR gives
shift-fontone native projection API that the preview bridge can consume in a follow-up. It intentionally does not add preview DTOs, workspace transport, TanStack Query integration, or grid UI.Resolution semantics
Validation
pnpm test: all Turbo test tasks passed, including 503 desktop testspnpm typecheckcargo clippy --workspace --all-targets -- -D warningsFoundation for #150; does not close it.