getStats メソッドを追加する #212
Merged
getStats メソッドを追加する #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
t-miya
reviewed
Nov 14, 2025
| suspendCancellableCoroutine { continuation -> | ||
| // 現在の PeerChannel インスタンスを取得 | ||
| val currentPeer = peer | ||
| // PeerChannel がまだ存在しない場合のガード |
Contributor
There was a problem hiding this comment.
切断済みの場合でも null のはずなので まだ はいらなそうです
t-miya
reviewed
Nov 14, 2025
| val currentPeer = peer | ||
| // PeerChannel がまだ存在しない場合のガード | ||
| if (currentPeer == null) { | ||
| // 結果なしを即時返却 |
Contributor
There was a problem hiding this comment.
関数ドキュメントにも書いていますが、結果なし を返しているのではなく、null を明示的に返すようにしているので null を返す、にした方がよさそうです
t-miya
reviewed
Nov 14, 2025
|
|
||
| currentPeer.getStats { report -> | ||
| // コルーチンがまだアクティブな場合に結果を返却 | ||
| // そうでない場合は何もしない |
Contributor
There was a problem hiding this comment.
何もしないで大丈夫なんでしたっけ
continuation.resume(null) で終わる必要ないですか？
Contributor
Author
There was a problem hiding this comment.
大丈夫です。
すでにキャンセルされてしまってるので resume すると例外が発生するので、例外発生させるのではなくここはキャンセルされた場合スルーするようにしています。
本来はキャンセルされたときの処理を書けという感じなのですが、ラップしてる非同期コールバックの getStats 呼び出しをキャンセルする方法がなさそうなので、このようにしています。
t-miya
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.