シグナリング offer メッセージの定義を更新する #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
commented
Jan 8, 2025
| var signalingNotifyMetadata = SignalingNotifyMetadata() | ||
| if let clinetId = dict["client_id"] as? String { | ||
| signalingNotifyMetadata.clientId = clinetId | ||
| if let clientId = dict["client_id"] as? String { |
zztkm
commented
Jan 8, 2025
|
|
||
| if let authzMetada = dict["authz_metadata"] { | ||
| signalingNotifyMetadata.authzMetadata = authzMetada | ||
| if let authzMetadata = dict["authz_metadata"] { |
torikizi
approved these changes
Jan 8, 2025
Contributor
torikizi
left a comment
torikizi
left a comment
There was a problem hiding this comment.
修正ありがとうございます。動作も問題なさそうでした。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionsimulcastMulticodecspotlightchannelIdsessionIdaudioaudioCodecTypeaudioBitRatevideovideoCodecTypevideoBitRateThis pull request includes several changes to the
SignalingOfferstructure inSora/Signaling.swiftand some corrections in theserializeDatafunction. The most important changes include adding new fields to theSignalingOfferstructure, updating theCodableconformance for these fields, and fixing typos in theserializeDatafunction.Additions to
SignalingOfferstructure:version,simulcastMulticodec,spotlight,channelId,sessionId,audio,audioCodecType,audioBitRate,video,videoCodecType, andvideoBitRateto theSignalingOfferstructure. [1] [2] [3]Codable conformance updates:
Codableconformance ofSignalingOfferto include the new fields in theCodingKeysenumeration and the correspondingdecodeandencodemethods. [1] [2]Typo corrections:
serializeDatafunction by changingclinetIdtoclientIdandauthzMetadatoauthzMetadata. [1] [2]Documentation updates:
CHANGES.mdto reflect the addition of new fields to theSignalingOfferstructure.