libwebrtc を m132.6834.5.3 にアップデートする #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torikizi
approved these changes
Jan 30, 2025
Contributor
torikizi
left a comment
torikizi
left a comment
There was a problem hiding this comment.
修正ありがとうございます。一点だけ確認をお願いします。
| public static let maintenanceVersion = "3" | ||
|
|
||
| /// WebRTC フレームワークのソースコードのリビジョン | ||
| public static let revision = "afaf497805cbb502da89991c2dcd783201efdd08" |
Contributor
There was a problem hiding this comment.
フレームワークのソースコードのリビジョンはアップデートしなくても大丈夫でしょうか？
Contributor
Author
There was a problem hiding this comment.
WebRTC.xcframework/build_info.json を確認したところ同じ値だったので問題ありません！
{
"branch": "M132",
"commit": "5",
"revision": "afaf497805cbb502da89991c2dcd783201efdd08",
"maint": "3"
}
Contributor
There was a problem hiding this comment.
sora-ios-sdk-specs の build_info.json を確認して同じ値だから更新の必要なしということでしょうか？であれば大丈夫です。
ありがとうございます。
Contributor
Author
There was a problem hiding this comment.
webrtc-build で配布されている、webrtc.ios.tar.gz を解凍すると webrtc/Frameworks/WebRTC.xcframework/build_info.json が入っていて、Sora/PackageInfo.swift はそこの値をベースにしています。
なので、build_info.json と一致しているので問題ないという意味になります
Contributor
There was a problem hiding this comment.
https://github.com/shiguredo-webrtc-build/webrtc-build の方を見ているのですね。理解できました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
※ README の更新は不要でした
This pull request includes updates to the WebRTC version used in the project. The primary changes involve updating the WebRTC framework version across various configuration files and documentation.
WebRTC Version Update:
CHANGES.md: Updated to reflect the new WebRTC versionm132.6834.5.3.Package.swift: Updated the WebRTC framework version and checksum to132.6834.5.3. [1] [2]Podfile: Updated the WebRTC pod version to132.6834.5.3.Podfile.dev: Updated the WebRTC pod version to132.6834.5.3.Sora.podspec: Updated the WebRTC dependency version to132.6834.5.3.Sora/PackageInfo.swift: Updated the WebRTC maintenance version to3.