scaleResolutionDownTo 追加 #228
Merged
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torikizi
reviewed
Feb 4, 2025
Contributor
torikizi
left a comment
torikizi
left a comment
There was a problem hiding this comment.
修正ありがとうございます。一点だけコメントしました。
Sora/Signaling.swift
Outdated
| /// 映像解像度を送信前に下げる度合 | ||
| public let scaleResolutionDownBy: Double? | ||
|
|
||
| /// エンコーディングを制限する最大の寸法 |
Contributor
There was a problem hiding this comment.
/// エンコーディングを制限する最大のサイズ
とかの方が良いかもしれません。
zztkm
deleted the
feature/simulcast-encodings-scale-resolution-down-to
branch
Contributor
Author
|
!sonnet レビューして |
|
Claude finished @zztkm's task —— View job • コードレビュー完了コードレビュー結果優先度: 高
優先度: 中
優先度: 低
実装品質良い点:
改善の余地:
変更点とリリースノートの整合性✅ 確認済み: CHANGES.md の記載内容と実装が一致している 総合評価実装は全体的に適切だが、上記の指摘事項の修正により、コードの品質をさらに向上できる。特に優先度: 高の項目は修正を推奨する。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scaleResolutionDownToを追加するThis pull request includes changes to add a new encoding parameter,
scaleResolutionDownTo, for simulcast video in the WebRTC implementation. The changes involve updates to both the documentation and the codebase to support this new parameter.Documentation Updates:
CHANGES.md: Added an entry for the new encoding parameterscaleResolutionDownTo.Codebase Updates:
Sora/PeerChannel.swift: Added support for logging and setting thescaleResolutionDownToparameter in theRTCRtpSenderextension.Sora/Signaling.swift:SignalingOfferstruct: Added thescaleResolutionDownToproperty.SignalingOfferstruct: Updated thetoParametersmethod to include thescaleResolutionDownToparameter.SignalingOffer.Configuration: Added a private structScaleResolutionDownTofor JSON decoding and updated theCodableextension to handle this new parameter. [1] [2] [3]