-
Notifications
You must be signed in to change notification settings - Fork 10
swift-format と SwiftLint 実行用の Makefile を追加する #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntas
reviewed
Feb 12, 2025
Makefile
Outdated
| @@ -0,0 +1,17 @@ | |||
| .PHONY: fmt fmt-lint lint | |||
|
|
|||
| # フォーマット (swift-format) | |||
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
カタカナの説明いらないでしょ ...
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
似たようなコマンド群なので合っても良いかなと思ったんですが、ちゃんと見たらわかるし不要ですね...、消します。
voluntas
reviewed
Feb 12, 2025
voluntas
reviewed
Feb 12, 2025
voluntas
reviewed
Feb 12, 2025
Co-authored-by: V <nakai@shiguredo.jp>
Co-authored-by: V <nakai@shiguredo.jp>
Co-authored-by: V <nakai@shiguredo.jp>
torikizi
reviewed
Feb 12, 2025
voluntas
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the dependency management and the addition of a Makefile for formatting and linting Swift code. The most important changes include the removal of
Podfile.dev, updates to GitHub Actions, and the addition of commands forswift-formatandSwiftLintin the Makefile.Dependency management updates:
CHANGES.md: RemovedPodfile.devdue to migration to Swift Package Manager and updated GitHub Actions to stop usingPodfile.dev.Makefile additions:
Makefile: Added commands forswift-formatandSwiftLint, allowing individual execution of these commands and a combinedallcommand to run all checks.