Skip to content

Conversation

@zztkm
Copy link
Contributor

@zztkm zztkm commented Feb 12, 2025

  • [ADD] swift-format と SwiftLint 実行用の Makefile を追加する
    • lint-format.sh で実行していたコマンドを個別に実行できるようにした

This pull request includes updates to the dependency management and the addition of a Makefile for formatting and linting Swift code. The most important changes include the removal of Podfile.dev, updates to GitHub Actions, and the addition of commands for swift-format and SwiftLint in the Makefile.

Dependency management updates:

  • CHANGES.md: Removed Podfile.dev due to migration to Swift Package Manager and updated GitHub Actions to stop using Podfile.dev.

Makefile additions:

  • Makefile: Added commands for swift-format and SwiftLint, allowing individual execution of these commands and a combined all command to run all checks.

@zztkm zztkm requested a review from torikizi February 12, 2025 07:47
@zztkm zztkm self-assigned this Feb 12, 2025
Makefile Outdated
@@ -0,0 +1,17 @@
.PHONY: fmt fmt-lint lint

# フォーマット (swift-format)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

カタカナの説明いらないでしょ ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

似たようなコマンド群なので合っても良いかなと思ったんですが、ちゃんと見たらわかるし不要ですね...、消します。

zztkm and others added 3 commits February 12, 2025 16:54
Co-authored-by: V <nakai@shiguredo.jp>
Co-authored-by: V <nakai@shiguredo.jp>
Co-authored-by: V <nakai@shiguredo.jp>
torikizi

This comment was marked as resolved.

@zztkm zztkm merged commit 51f50f7 into develop Feb 12, 2025
4 checks passed
@zztkm zztkm deleted the feature/add-makefile-for-swift-format branch February 12, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants