Skip to content

Conversation

@zztkm
Copy link
Contributor

@zztkm zztkm commented Apr 7, 2025

SDK ユーザーに影響がないため、misc としています。

  • [UPDATE] WebRTCConfigration.swift を WebRTCConfiguration.swift にリネームする

@zztkm zztkm requested a review from Copilot April 7, 2025 03:06
@zztkm zztkm self-assigned this Apr 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Sora.xcodeproj/project.pbxproj: Language not supported

@zztkm zztkm changed the title [WIP] WebRTCConfigration.swift を WebRTCConfiguration.swift にリネームする WebRTCConfigration.swift を WebRTCConfiguration.swift にリネームする Apr 7, 2025
@zztkm zztkm requested a review from miosakuma April 7, 2025 03:12
@zztkm
Copy link
Contributor Author

zztkm commented Apr 7, 2025

Sora iOS SDK QuickStart でビルドが通るかの確認は行いました

CHANGES.md Outdated
- @zztkm
- [UPDATE] フォーマッターとリンターの実行を Makefile に移行したため、不要になった lint-format.sh を削除
- @zztkm
- [UPDATE] WebRTCConfigration.swift を WebRTCConfiguration.swift にリネームする
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作は変わらないのですが、本体ソースの修正ではあるので通常の方に入れた方がいいかなと思います。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c6e5e5d で修正しました。

Copy link
Contributor

@miosakuma miosakuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました。

@zztkm zztkm merged commit 68a1aaa into develop Apr 7, 2025
4 checks passed
@zztkm zztkm deleted the feature/rename-typo-filename branch April 7, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants