[DO NOT MERGE] Hotfix/2025.1.2 #251
Open
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voluntas
reviewed
Apr 30, 2025
| createAnswer(isSender: false, | ||
| offer: reOffer, | ||
| constraints: webRTCConfiguration.nativeConstraints) | ||
| { answer, error in | ||
| self.lock.lock() |
There was a problem hiding this comment.
- なぜここに移動したのかをコメントで書く
- self. を付けた理由も書けるなら書く
There was a problem hiding this comment.
95efb64 でこの対応の理由を書きました。
voluntas
reviewed
Apr 30, 2025
CHANGES.md
Outdated
|
|
||
| **リリース日**: 2025-05-02 | ||
|
|
||
| - [FIX] マルチストリーム利用時に SDP 再ハンドシェイク中に SDK が終了処理をした際にレースコンディションによりクラッシュする問題を修正する |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
注意: マージ作業は
git flow hotfix finishで行うため、GitHub 上ではレビューのみを行い、マージは行いません。