RTCAudioTrackSink ラッパーを MediaStream に追加する #283
Merged
+34
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
commented
Dec 15, 2025
Contributor
Author
|
!haiku レビューして |
This comment was marked as resolved.
This comment was marked as resolved.
zztkm
commented
Dec 15, 2025
|
|
||
| func addAudioTrackSink(_ sink: RTCAudioTrackSink) { | ||
| Logger.debug(type: .mediaStream, message: "add audio track sink \(sink)") | ||
| nativeAudioTrack?.add(sink) |
Contributor
Author
There was a problem hiding this comment.
RTCAudioTrack の addSink 内で sink の重複チェックをしているので、iOS SDK での重複チェックは不要。
Contributor
Author
There was a problem hiding this comment.
これコードコメントに書いてあったほうが良さそう。
miosakuma
approved these changes
Dec 15, 2025
zztkm
changed the title
t-miya
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.