github actions ビルドの ios バージョンを更新 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zztkm
reviewed
Jan 14, 2026
Comment on lines
100
to
104
| - [FIX] GitHub Actions のビルド環境を更新する | ||
| - GitHub Actions でのビルドが通らなくなったため | ||
| - Xcode の version を 16.4 に変更 | ||
| - SDK を iOS 18.5 に変更 | ||
| - @t-miya |
Contributor
There was a problem hiding this comment.
FIX 残しても良いと思いました。[対応はお任せ]
自分が FIX を残すとしたら、経緯がわかりやすいように PR の URL か Actions の履歴のリンクを貼って、「ビルドが通らなくなった」をより詳細に「macOS 15 利用中に error: iOS 18.4 Platform Not Installed. というエラー出るようになったため、SDK を iOS 18.5 に上げた」とか書くと思います。
Contributor
Author
There was a problem hiding this comment.
FIX の内容を戻しました。またエラーの内容を記載するように修正しました。
zztkm
approved these changes
Jan 14, 2026
Contributor
zztkm
left a comment
zztkm
left a comment
There was a problem hiding this comment.
CHANGES の記載方針についてちょっと意見を書きましたが、基本的な対応としては問題ないと思うので、LGTM です 👍🏼
zztkm
approved these changes
Jan 14, 2026
Contributor
zztkm
left a comment
zztkm
left a comment
There was a problem hiding this comment.
[FIX] 部分の CHANGES が残してあって、背景がわかりやすくなったと思います、LGTM です!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
26.2 に更新