Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(packages/monaco): decomposed into logical parts #931

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

azabroflovski
Copy link
Contributor

Description

  • removed any types
  • added indentations for better readability
  • helper functions moved to ./utils.ts
  • types in ./types.ts

Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 90ba29e
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/67b0899355827200082bd9b2
😎 Deploy Preview https://deploy-preview-931--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 90ba29e
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/67b089935711ef0008f2bd57
😎 Deploy Preview https://deploy-preview-931--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azabroflovski azabroflovski force-pushed the refactor/packages-monaco branch from b3c02a6 to 383a0e8 Compare February 15, 2025 12:30
- removed `any` types
- added indentations for better readability
- helper functions moved to `./utils.ts`
- types in `./types.ts`
@azabroflovski azabroflovski force-pushed the refactor/packages-monaco branch from 383a0e8 to 90ba29e Compare February 15, 2025 12:33
@antfu antfu merged commit db6910f into shikijs:main Feb 15, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants