Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twoslash)!: make default moduleResolution to bundler #936

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

antfu
Copy link
Member

@antfu antfu commented Feb 18, 2025

moduleResolution: Bundler should be pretty compatible with both modern (node16+) and legacy (node10) resolution, and I believe it's a better and modern default than typescript's current default node10. This would also help the ecosystem to move forward to targeting node16 resolutions, like #923

Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 493b097
🔍 Latest deploy log https://app.netlify.com/sites/shiki-matsu/deploys/67b42da8ed672e0008790d01
😎 Deploy Preview https://deploy-preview-936--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 493b097
🔍 Latest deploy log https://app.netlify.com/sites/shiki-next/deploys/67b42da830252f0008e3c01f
😎 Deploy Preview https://deploy-preview-936--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (55c1554) to head (493b097).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   95.17%   95.18%           
=======================================
  Files          89       89           
  Lines        7302     7310    +8     
  Branches     1514     1514           
=======================================
+ Hits         6950     6958    +8     
  Misses        344      344           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antfu antfu marked this pull request as ready for review February 18, 2025 07:07
@antfu antfu merged commit e924d4b into main Feb 18, 2025
14 checks passed
@antfu antfu deleted the feat/twoslash-module-resolution branch February 18, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant