feat: treat entire block as mermaid #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a code block was required to treat the code as mermaid. This does away with that requirement.
❌ Deploy Preview for textmate-grammars-themes failed.
|
|
Does this need to be patched here? Wouldn't this be better changed in the upstream grammar? |
5 tasks
My bad, I didn't realize there's an upstream. Will propose a fix there. Thank you for pointing that out! Update: looks like the upstream is https://github.com/bpruitt-goddard/vscode-mermaid-syntax-highlight/blob/master/syntaxes/mermaid.tmLanguage-mdx.yaml , which is a mermaid code block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a code block was required to treat the code as mermaid. This does away with that requirement.
Before:
After:
I also did some adhoc testing that this doesn't break/change rendering between markdown code blocks.