Protect leaderboard privacy and normalize legacy aliases - #120
Merged
Conversation
Only show rows with >=1hr saved, capped at 5, so the board never hints at the real number of users; the viewer's own row always renders regardless of their usage. Also compact legacy "Adjective Noun NN" display names server-side so already-stored names lose their spaces for every viewer, not just after the writing device relaunches. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The reveal threshold and row cap were only applied in the native client; the public API still returned all rows, so a direct request exposed sub-60-minute users. Move the filter/cap into createLeaderboardHandler, which lets the original client code (using board.you.inTop) work correctly unmodified. Also fix _leaderboardAlias.js accepting any two-digit number where Swift's compactLegacyDefault only accepts 10-99, which caused 00-09-suffixed names to be rewritten when the native app would have left them untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
inTopcalculated against the filtered standings.Verification
npm install— passed; 0 vulnerabilitiesnpm run test:api— 7 passedpython3 -m pytest -q— 287 passed, 1 optional skipcd native && swift build— passed with Xcode 26.5 / Swift 6.3.2; existing deprecation warnings onlynpm run build— passeduvx ruff check voiceflow/— passednpm audit --audit-level=high— 0 vulnerabilitiesinTop: falseNo version, tag, release, or native DMG workflow changes are included.