Open
Conversation
|
Hello! If you are still interested about this project, I decided to make a fork: https://github.com/Cucuzacu/ELVM-Remastered. I will constantly update it to support more and more C functions. I added your strcspn implementation to my fork, along with scanf. Maybe you can help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought of implementing it using a 256-bit bitmap. Like storing characters in
s2like a blacklist to stop iteration ofs1. However, it might be an overkill to create a bitmap for overall use-cases. Under most circumstances, the length ofs2should be way smaller thans1. Thus, I decided to copy the implementation from Bionic like some other functions instring.h.I was planning to write some test cases, but I noticed there are no test cases for functions like
strchrand the test structure looked a bit weird to me. It might be better to refactor the tests at some point. Still, I can write tests similar tofgetsif you'd like.