Remove obsolete IsValid methods #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated `Luhn.IsValid` methods have been removed from the codebase, including tests and spanning overloads. Users should now migrate to the updated `IsValidLuhnNumber` and `IsValidLuhnCheckDigit` methods for validation tasks. Updates are reflected in the changelog for clarity. Resolves: No entry
Replaced `IsNumber` with `ValidateAndTrimNumber` to improve readability and better communicate its purpose. Introduced `AsciiCodeForZero` constant for cleaner ASCII code calculations. Updated method references and comments to reflect these changes, enhancing maintainability. Resolves: No entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
Luhnclass and its associated tests. The most significant changes involve the removal of obsoleteIsValidmethods and the introduction of theValidateAndTrimNumbermethod for better validation. Additionally, theAsciiCodeForZeroconstant has been added for improved code readability.Changes to
Luhnclass:IsValidmethods and replaced their usage withIsValidLuhnNumberandIsValidLuhnCheckDigitmethods. [1] [2] [3] [4] [5]ValidateAndTrimNumbermethod to replaceIsNumberfor better validation and trimming of input numbers. [1] [2]AsciiCodeForZeroconstant to improve code readability in digit extraction methods. [1] [2] [3]ComputeLuhnCheckDigitandIsValidLuhnNumbermethods to useValidateAndTrimNumberfor input validation. [1] [2] [3] [4]Changes to tests:
IsValidmethods in test cases and replaced them withIsValidLuhnNumberandIsValidLuhnCheckDigitmethods. [1] [2] [3] [4] [5] [6]Documentation:
CHANGELOG.mdto reflect the removal ofLuhn.IsValidmethods.