Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ConvertAlphaNumericToNumeric to AlphaNumericToNumeric #85

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

shinji-san
Copy link
Owner

@shinji-san shinji-san commented Jan 1, 2025

This pull request focuses on renaming the method ConvertAlphaNumericToNumeric to AlphaNumericToNumeric across the codebase for consistency and clarity. The changes span multiple files, including documentation, source code, and test cases.

Method Renaming:

  • src/Luhn.cs: Renamed method ConvertAlphaNumericToNumeric to AlphaNumericToNumeric.

Documentation Updates:

  • CHANGELOG.md: Updated to reflect the renaming of Luhn.ConvertAlphaNumericToNumeric to Luhn.AlphaNumericToNumeric.
  • README.md: Updated references to ConvertAlphaNumericToNumeric method to AlphaNumericToNumeric in multiple sections. [1] [2] [3]

Test Updates:

@shinji-san shinji-san self-assigned this Jan 1, 2025
Updated method name for clarity and consistency across the codebase.
Adjusted all references in the code, tests, README, and CHANGELOG to reflect the new method name.

Resolves: No entry
@shinji-san shinji-san force-pushed the fix-ConverterMethodName branch from eafd58f to 0993e9a Compare January 1, 2025 21:47
@shinji-san shinji-san merged commit bfbb5eb into develop Jan 1, 2025
3 checks passed
@shinji-san shinji-san deleted the fix-ConverterMethodName branch January 1, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant