Refactor exceptions to use InvalidCharacterException.
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `ArgumentException` with the new `InvalidCharacterException` for better semantic clarity when handling invalid input. Added `InvalidCharacterException` class and updated related tests accordingly to align with these changes. Updated the changelog to document the addition. Resolves: No entry
shinji-san
force-pushed
the
feature-InvalidCharacterException
branch
from
f3e8ac2 to
d343f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new exception class
InvalidCharacterExceptionand updates various methods and tests to use this new exception instead ofArgumentException. Additionally, it includes renaming and refactoring of test methods for clarity.New Exception Class:
InvalidCharacterExceptionto handle cases where an input string contains invalid characters. (src/InvalidCharacterException.cs)Method Updates:
ArgumentExceptionwithInvalidCharacterExceptionin theAlphaNumericToNumericandValidateAndTrimNumbermethods. (src/Luhn.cs) [1] [2] [3] [4]Test Updates:
InvalidCharacterExceptioninstead ofArgumentException. (tests/LuhnTest.cs) [1] [2] [3]tests/LuhnTest.cs) [1] [2] [3] [4] [5] [6] [7] [8]Documentation:
CHANGELOG.mdto include the addition ofInvalidCharacterExceptionand the renaming ofLuhn.ConvertAlphaNumericToNumeric. (CHANGELOG.md)