fix: add dependency existence verification to design workflow#147
Merged
fix: add dependency existence verification to design workflow#147
Conversation
Design documents could reference non-existent components as "existing" dependencies without verification, leading to implementation failures. Add verification step to technical-designer agents and realizability check to document-reviewer Gate 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
technical-designerandtechnical-designer-frontendagents — verifies each assumed dependency via Grep/Glob before design proceeds, with three-way classification (found in codebase / external dependency / requires new creation)document-reviewerGate 1 — cross-checks claimed "existing" dependencies against the codebase during reviewagents-en/) and Japanese (agents-ja/) environmentsProblem
Design documents could describe components as "existing" without verification. When those dependencies turned out to be missing or had mismatched signatures, it caused implementation failures that were only discovered late in the workflow.
Test plan
technical-designeron a project referencing a non-existent internal component — verify it is flagged as "requires new creation"technical-designeron a project referencing an external API — verify it is recorded as "external dependency"document-revieweron a Design Doc claiming an existing dependency that does not exist — verifycritical/feasibilityissue is raiseddocument-revieweron a Design Doc where a claimed dependency has a different signature — verifyimportant/consistencyissue is raised🤖 Generated with Claude Code