chore: migrate circular dependency checker from madge to dpdm#152
Merged
chore: migrate circular dependency checker from madge to dpdm#152
Conversation
madge has stale indirect dependencies with known security vulnerabilities (brace-expansion ReDoS) that are not being addressed upstream. As a boilerplate, shipping an unmaintained tool with audit warnings is irresponsible. dpdm is actively maintained (last release 2026-01), uses TypeScript compiler API directly, and has a shallower dependency tree. - Remove madge and .madgerc configuration - Add dpdm with equivalent CLI options for check:deps - Remove unused check:deps:graph script (graph.svg was never generated) - Bump version to 1.19.1 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check:deps).madgercconfig file (settings migrated to dpdm CLI options)check:deps:graphscript (graph.svg was never generated)Motivation
madge has stale indirect dependencies with known security vulnerabilities (brace-expansion ReDoS via dependency-tree → precinct → detective-typescript → @typescript-eslint/typescript-estree → minimatch). As a boilerplate that scaffolds new projects, shipping an unmaintained tool with
npm auditwarnings is irresponsible to downstream users.dpdm is actively maintained (last release 2026-01), uses TypeScript compiler API directly, and has a shallower dependency tree.
Test plan
npm run check:depsruns successfully with dpdmnpm run check:codechain (check → check:unused → check:deps → build) passesnpm auditreturns 0 vulnerabilities afternpm audit fixCo-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com