Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 27, 2025

No description provided.

@koush koush requested a review from Copilot September 3, 2025 15:05

This comment was marked as outdated.

@koush koush requested a review from Copilot September 3, 2025 15:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dependency on lodash's inRange utility function by replacing its usage with native JavaScript comparison operators. The change eliminates an external dependency while maintaining the same functionality for port range validation in WebRTC tests.

Key changes:

  • Removed lodash/inRange import statements from test files
  • Replaced inRange() calls with equivalent native JavaScript comparisons using >= and < operators

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/webrtc/tests/transport/ice.test.ts Removed lodash/inRange import and replaced two inRange() calls with native comparison operators
packages/webrtc/tests/integrate/peerConnection.test.ts Removed lodash/inRange import and replaced one inRange() call with native comparison operators

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@koush koush merged commit b0eff55 into shinyoshiaki:develop Sep 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants