Skip to content

Conversation

@koush
Copy link
Collaborator

@koush koush commented Aug 28, 2025

No description provided.

@koush koush requested a review from Copilot August 28, 2025 05:04
@koush koush marked this pull request as draft August 28, 2025 05:04

This comment was marked as outdated.

@koush
Copy link
Collaborator Author

koush commented Aug 28, 2025

I had qwen 480b analyze the code and it came up with this fix which seemed to work. I'll need to clean it up to determine what the underlying issue actually was, as this seems to have tried a lot of different things.

@koush
Copy link
Collaborator Author

koush commented Aug 28, 2025

fixes #495

@koush koush marked this pull request as ready for review August 28, 2025 16:06
@koush
Copy link
Collaborator Author

koush commented Aug 28, 2025

I removed the unnecessary changes, I believe the issues were entirely caused by improper management of the queues

@koush koush requested a review from Copilot August 28, 2025 16:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues with SCTP stream reconfiguration when data channels are closed rapidly, preventing duplicate reconfig requests and improving the reliability of the reconfiguration process.

  • Adds duplicate prevention checks to prevent the same channel ID from being added multiple times to the reconfiguration queue
  • Implements proper cleanup of pending reconfiguration requests when channels are closed outside of established state
  • Resets RTO backoff and failure counters on successful reconfigurations to improve retry behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/webrtc/src/transport/sctp.ts Adds duplicate prevention for reconfig queue and cleanup of pending requests when channels close
packages/sctp/src/sctp.ts Implements deduplication in reconfig queue processing and resets RTO/failure counters on success

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@koush koush marked this pull request as draft August 28, 2025 16:42
@koush koush marked this pull request as ready for review September 1, 2025 19:11
@koush
Copy link
Collaborator Author

koush commented Sep 2, 2025

@shinyoshiaki ready to review.

@shinyoshiaki shinyoshiaki merged commit 25cf0a9 into shinyoshiaki:develop Sep 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants