-
Notifications
You must be signed in to change notification settings - Fork 39
fix issues with reconfig stream on fast data channel close #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I had qwen 480b analyze the code and it came up with this fix which seemed to work. I'll need to clean it up to determine what the underlying issue actually was, as this seems to have tried a lot of different things. |
|
fixes #495 |
|
I removed the unnecessary changes, I believe the issues were entirely caused by improper management of the queues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues with SCTP stream reconfiguration when data channels are closed rapidly, preventing duplicate reconfig requests and improving the reliability of the reconfiguration process.
- Adds duplicate prevention checks to prevent the same channel ID from being added multiple times to the reconfiguration queue
- Implements proper cleanup of pending reconfiguration requests when channels are closed outside of established state
- Resets RTO backoff and failure counters on successful reconfigurations to improve retry behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/webrtc/src/transport/sctp.ts | Adds duplicate prevention for reconfig queue and cleanup of pending requests when channels close |
| packages/sctp/src/sctp.ts | Implements deduplication in reconfig queue processing and resets RTO/failure counters on success |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@shinyoshiaki ready to review. |
No description provided.