Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Sep 4, 2025

No description provided.

@Uzlopak Uzlopak changed the title chore: use for...of instead of forEach chore: use for...of instead of forEach in dtls Sep 4, 2025
@koush
Copy link
Collaborator

koush commented Sep 4, 2025

even I prefer using for loops but i personally dont think restyling the entire code base is appropriate. there is no tangible benefit to this change.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 4, 2025

@koush

  1. biome is complaining
  2. forEach is always slower. For each function call the engine needs to create a scope/context.

I am also active in fastify, nodejs and undici, and we always try to avoid these array helper functions, because they are a performance bottleneck.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 13, 2025

CLeaning up my open pr list

@Uzlopak Uzlopak closed this Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants