Skip to content

Conversation

@koush
Copy link
Collaborator

@koush koush commented Oct 29, 2025

The circular import for RtcpPacketConverter is triggering warnings in my bundler, though it works fine. I resolved this.

@koush koush requested review from Copilot and shinyoshiaki October 29, 2025 18:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the RTCP serialization logic by moving the serialize static method from RtcpPacketConverter to RtcpHeader. This consolidates header serialization functionality into the RtcpHeader class where it logically belongs.

  • Moved RtcpPacketConverter.serialize static method to RtcpHeader.serialize
  • Updated all call sites across the codebase to use the new location
  • Changed import statements from type imports to regular imports where needed

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/rtp/src/rtcp/header.ts Added static serialize method to RtcpHeader class
packages/rtp/src/rtcp/rtcp.ts Removed serialize static method from RtcpPacketConverter class
packages/rtp/src/rtcp/sr.ts Updated to call RtcpHeader.serialize and import RtcpHeader
packages/rtp/src/rtcp/rr.ts Updated to call RtcpHeader.serialize and import RtcpHeader
packages/rtp/src/rtcp/sdes.ts Updated to call RtcpHeader.serialize and changed from type import to regular import
packages/rtp/src/rtcp/psfb/index.ts Updated to call RtcpHeader.serialize and changed from type import to regular import
packages/rtp/tests/rtcp/rtcp.test.ts Updated test to call RtcpHeader.serialize and added RtcpHeader import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant