fix: prune by block height so a lost queue does not stop pruning - #381
Open
mennatnaga wants to merge 3 commits into
Open
fix: prune by block height so a lost queue does not stop pruning#381mennatnaga wants to merge 3 commits into
mennatnaga wants to merge 3 commits into
Conversation
mennatnaga
force-pushed
the
menna/pruner-bounded-stop
branch
from
September 2, 2026 02:26
e7d050e to
66a1b8b
Compare
mennatnaga
force-pushed
the
fix/pruner-height-ceiling-360
branch
from
September 2, 2026 02:26
52ddce2 to
c79c28b
Compare
mennatnaga
marked this pull request as ready for review
September 2, 2026 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #360.
The pruner only knew what its in-memory queue told it, so a host that lost the queue on restart pruned nothing at all. This adds a sweep that reads the store directly and removes anything below
highest_block - max_blocks.The sweep and the queue drain get a
max_docs_per_cyclebudget each instead of sharing one, otherwise a queue far enough over its threshold takes the whole budget and the sweep never runs.