Drop PHP < 8.1 support, switch to PhpToken, and update dependencies #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update composer.json to require PHP ^8.0 - Refactor UsedSymbolExtractor to use PhpToken::tokenize() instead of token_get_all() - Remove all PHP_VERSION_ID < 80000 compatibility code paths - Update phpstan.neon.dist and phpcs.xml.dist to target PHP 8.0 - Remove unnecessary (string) casts since substr() always returns string in PHP 8.0+ - Remove PHP 8.0 version guard from attribute test case
1 task
- Replace slevomat/coding-standard with shipmonk/coding-standard ^0.2.0 - Update phpunit/phpunit to ^10.5 - Update phpstan/phpstan to ^2.1 - Update phpstan/phpstan-phpunit to ^2.0 - Update phpstan/phpstan-strict-rules to ^2.0 - Simplify phpcs.xml.dist to use ShipMonkCodingStandard ruleset - Update phpstan.neon.dist phpVersion to 80100 - Apply code style fixes from new coding standard
JanTvrdik
changed the title
- Update CI to run checks on PHP 8.5 instead of 8.3 - Fix phpunit command (remove -vvv which is unsupported in PHPUnit 10) - Use constructor property promotion in: - PathToScan - SymbolUsage - UnusedSymbolIgnore - UnusedErrorIgnore - Printer - ConsoleFormatter - JunitFormatter - Initializer
janedbal
requested changes
Nov 27, 2025
janedbal
approved these changes
Nov 27, 2025
Member
|
Member
Author
|
I completely forgot about this one =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UsedSymbolExtractorto use the nativePhpTokenclass instead oftoken_get_all()slevomat/coding-standardwithshipmonk/coding-standard ^0.2.0phpunit/phpunitto^10.5phpstan/phpstanto^2.1phpstan/phpstan-phpunitto^2.0phpstan/phpstan-strict-rulesto^2.0phpcs.xml.distto use ShipMonkCodingStandard rulesetTest plan