Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnforceIteratorToArrayPreserveKeysRule: fix test for latest PHPStan #293

Merged
merged 1 commit into from
Dec 11, 2024
Merged

EnforceIteratorToArrayPreserveKeysRule: fix test for latest PHPStan #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions tests/Rule/data/EnforceIteratorToArrayPreserveKeysRule/code.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

namespace EnforceIteratorToArrayPreserveKeysRule;

/**
* Isolate the generator, so that PHPStan is not aware of the keys.
*/
function passThru(\Generator $iterable): \Generator {
yield from $iterable;
}

$objectAsKey = function () {
yield new \stdClass => 1;
};
Expand All @@ -17,15 +24,15 @@
};


iterator_to_array($objectAsKey()); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss.
iterator_to_array($dataLoss()); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss.
iterator_to_array($noKeys()); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss.
iterator_to_array(passThru($objectAsKey())); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss.
iterator_to_array(passThru($dataLoss())); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss.
iterator_to_array(passThru($noKeys())); // error: Calling iterator_to_array without 2nd parameter $preserve_keys. Default value true might cause failures or data loss.

iterator_to_array($objectAsKey(), false);
iterator_to_array($dataLoss(), false);
iterator_to_array($noKeys(), true);
iterator_to_array(... [$noKeys(), true]);
iterator_to_array(passThru($objectAsKey()), false);
iterator_to_array(passThru($dataLoss()), false);
iterator_to_array(passThru($noKeys()), true);
iterator_to_array(... [passThru($noKeys()), true]);
iterator_to_array(
preserve_keys: true,
iterator: $noKeys()
iterator: passThru($noKeys())
);
Loading