Skip to content

Commit 5baf8d8

Browse files
committed
Merge pull request #87 from HubSpot/version-1
Major upgrade to version 1
2 parents 1de7a2e + bef42b6 commit 5baf8d8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+3500
-4205
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
## v1.0.0
2+
- Coffeescript -> ES6
3+
- Proper UMD Wrapper
4+
- Update build steps
5+
- Add changelog
6+
- Provide minified CSS

CONTRIBUTING.md

+59
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# Contributing Guide
2+
3+
You will need:
4+
5+
- Node.js/io.js & npm
6+
- Bower
7+
- Gulp
8+
9+
10+
## Getting started
11+
12+
1. Fork the project
13+
2. Clone your forked project by running `git clone [email protected]:{
14+
YOUR_USERNAME }/tether.git`
15+
3. Run `npm install` to install both node modules and bower components
16+
4. Test that you can build the source by moving/renaming the existing `dist`
17+
directory and running `npm run build`
18+
5. Assuming everything went well, you should now have a `dist` directory that
19+
matches the one you moved in step 4
20+
21+
22+
## Writing code!
23+
24+
We use `gulp` to facilitate things like transpilation, minification, etc. so
25+
can you focus on writing relevant code. If there is a fix or feature you would like
26+
to contribute, we ask that you take the following steps:
27+
28+
1. Most of the _editable_ code lives in the `src` directory while built code
29+
will end up in the `dist` directory upon running `npm run build`.
30+
31+
2. Depending on how big your changes are, bump the version numbers appropriately
32+
in `bower.json` and `package.json`. We try to follow semver, so a good rule
33+
of thumb for how to bump the version is:
34+
- A fix to existing code, perform a patch bump e.g. x.x.0 -> x.x.1
35+
- New feature, perform a minor bump e.g. x.0.x -> x.1.x
36+
- Breaking changes such a rewrite, perform a major bump e.g.
37+
1.x.x -> 2.x.x
38+
39+
Versioning is hard, so just use good judgement and we'll be more than happy
40+
to help out.
41+
42+
__NOTE__: There is a `gulp` task that will automate some of the versioning.
43+
You can run `gulp version:{type}` where type is `patch|minor|major` to
44+
update both `bower.json` and `package.json` as well as add the appropriate
45+
git tag.
46+
47+
3. Provide a thoughtful commit message and push your changes to your fork using
48+
`git push origin master` (assuming your forked project is using `origin` for
49+
the remote name and you are on the `master` branch).
50+
51+
4. Open a Pull Request on GitHub with a description of your changes.
52+
53+
54+
## Testing
55+
56+
Work in progress. We are hoping to add some tests, so if you would like to help
57+
us get started, feel free to contact us through the Issues or open a Pull
58+
Request.
59+

README.md

+24-1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,29 @@ It aims to be the canonical implementation of this type of positioning, such tha
66

77
Take a look at the documentation for a more detailed explanation of why you should star it now to remember it for your next project.
88

9+
## Install
10+
11+
__npm__
12+
```sh
13+
$ npm install tether
14+
```
15+
16+
__bower__
17+
```sh
18+
$ bower install tether
19+
```
20+
21+
## Usage
22+
923
[![Tether Docs](http://i.imgur.com/YCx8cLr.png)](http://github.hubspot.com/tether/#usage)
1024

11-
### [Demo & Documentation](http://github.hubspot.com/tether/)
25+
[Demo & API Documentation](http://github.hubspot.com/tether/)
26+
27+
28+
## Contributing
29+
30+
We encourage contributions of all kinds. If you would like to contribute in some way, please review our [guidelines for contributing](CONTRIBUTING.md).
31+
32+
33+
## License
34+
Copyright © 2015 HubSpot - [MIT License](LICENSE)

bower.json

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
{
22
"name": "tether",
3-
"version": "0.7.2",
4-
"main": "tether.js",
3+
"version": "1.0.0",
54
"homepage": "https://github.hubspot.com/tether",
65
"authors": [
76
"Zack Bloom <[email protected]>",
87
"Adam Schwartz <[email protected]>"
98
],
9+
"maintainers": [
10+
"Nicholas Hwang <[email protected]>"
11+
],
1012
"description": "A client-side library to make absolutely positioned elements attach to elements in the page efficiently.",
1113
"keywords": [
1214
"javascript"
1315
],
1416
"license": "MIT",
17+
"main": "dist/js/tether.js",
1518
"ignore": [
1619
"**/.*",
1720
"node_modules",

coffee/abutment.coffee

-41
This file was deleted.

0 commit comments

Comments
 (0)