Major TGUI update #4870
Draft
Major TGUI update #4870
+30,901
−27,621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to tgui-ALL-of-it
…to tgui-ALL-of-it
Removes the SIGN() macro in favour of the new BYOND built-in sign() proc. Removes the unused SIGNV() macro. (cherry picked from commit 52eca26a47219f49af5e25376dabd761c92abf7e)
Adds the missing byond:// prefix to most href links for 516 compatibility. This was done using a simple find and replace so it may have missed some. (cherry picked from commit 27253f294bcac0b4f7d6568e5deb2ed4fae93826)
(cherry picked from commit 670bcf724da9343f46bee63a3ec3a89750d74501)
…3#254) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> This fixes chat not saving in 516. Supposedly fixes the ability to save chat logs however it did nto seem to work. Fixes assets not loading in UI. Check commit history for all the fixed 516 bugs. No more being blasted with light mode every time you relog! :cl: fix: [Byond 516] Fixes chat settings not saving /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: jimmyl <[email protected]> Co-authored-by: Lucy <[email protected]> Co-authored-by: Vallat <[email protected]> Co-authored-by: itsmeow <[email protected]> Co-authored-by: Aylong <[email protected]> (cherry picked from commit 9622ed7feaa96c6821d7c4416d62bdd5a53ab34f)
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes some 516 branch UI issues ## Why It's Good For The Game Fixes UIs! Important. ## Changelog :cl: fix: PAI menu now loads fix: Secure safe and friefcase now loads fix: The map should load properly now (Note this is a hack, the non hack version in TG is not compatible with our code) /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: The Sharkening <[email protected]> (cherry picked from commit cf4cb189b8648b1cff5e2690ce1b7b934313bc93)
This reverts commit 08be135.
…to tgui-ALL-of-it
…to tgui-ALL-of-it
…to tgui-ALL-of-it
…to tgui-ALL-of-it
github-actions
bot
added
DME Edit
TGUI
Dependencies
Code change
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…to tgui-ALL-of-it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Redoing #4574 without all the 516 stuff
Requires #4864 and #4798
Copies a bulk quanty of TG station TGUI updates. I did this by copy pasting the entire TGUI folder and working from there. This WILL cause some issues but cherry-picking everything by hand was not humanly possible imo.
Why It's Good For The Game
Something in this fixes tgui for 516 still and im not sure why.
Changelog
🆑
add: HOLY crap we use 516 now!
add: Modern TGUI styling and css (might be reverted)
code: Swapping from Inferno to React
code: Chat Reliability Layer
/:cl: