remove get,patch of CustomResourceDefinitions. #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
openshift-ci
bot
added
do-not-merge/work-in-progress
hasanawad94
force-pushed
the
fix-crd-permissions
branch
2 times, most recently
from
d163872 to
48d4f88
Compare
SaschaSchwarze0
requested changes
Apr 12, 2025
openshift-merge-robot
added
needs-rebase
hasanawad94
force-pushed
the
fix-crd-permissions
branch
4 times, most recently
from
f8a3cc0 to
958b01a
Compare
Signed-off-by: Hasan Awad <[email protected]>
hasanawad94
force-pushed
the
fix-crd-permissions
branch
from
958b01a to
4d9c515
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
hack/storage-version-migration.sh scriptis using permissions to patch CustomResourceDefinitions.The needed permissions were added to the script and then deleted after the script is done executing.
Fixes #1789
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes