-
-
Notifications
You must be signed in to change notification settings - Fork 395
Remove PHP 7.4 lock to Relay 0.7.0
#1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1011 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 822 822
Branches 286 286
=========================================
Hits 822 822 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As per the builds page, PHP 7.4 builds are only there for 0.7.0 on macOS. After this it fails to install on PHP 7.4 on macOS. Maybe the lock should be there only for macOS or builds for macOS can be added to the newer releases for PHP 7.4. |
You're right, we should have 7.4 builds. I'll check in with @michael-grunder tomorrow and make sure we have those. |
Quick update, in version v0.8.0 we dropped x86 and 7.4 builds on macOS. All other OS still have 7.4 and x86. I'll check if we can easily restore these, or if we need to block exclude macOS 7.4 from the |
@shivammathur: I tested the 7.4 Do we need to do anything to block name: Compatibility
on: [push]
jobs:
test:
name: ${{ matrix.runner }} (PHP ${{ matrix.php }})
runs-on: ${{ matrix.runner }}
timeout-minutes: 5
strategy:
matrix:
runner:
- macos-14
- macos-15
php:
- '7.4'
- '8.0'
- '8.1'
- '8.2'
- '8.3'
- '8.4'
env:
RELAY_VERSION: dev
steps:
- name: Install PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
extensions: msgpack, igbinary, redis
- name: Install Packages
if: ${{ startsWith(matrix.runner, 'macos') }}
run: |
brew install gsed # needed for gsed call in this workflow
brew install ck hiredis
- name: Install Relay (macOS)
if: ${{ startsWith(matrix.runner, 'macos') }}
run: |
ARCH=$(arch | sed -e 's/amd64\|x86_64/x86-64/')
RELAY_ARTIFACT="https://builds.r2.relay.so/$RELAY_VERSION/relay-$RELAY_VERSION-php${{ matrix.php }}-darwin-$ARCH.tar.gz"
RELAY_INI_DIR=$(php-config --ini-dir)
RELAY_EXT_DIR=$(php-config --extension-dir)
RELAY_TMP_DIR=$(mktemp -dt relay)
curl -sSL $RELAY_ARTIFACT | tar -xz --strip-components=1 -C $RELAY_TMP_DIR
sudo gsed -i "s/00000000-0000-0000-0000-000000000000/$(uuidgen)/" $RELAY_TMP_DIR/relay.so
cp $RELAY_TMP_DIR/relay.so $RELAY_EXT_DIR
cp $RELAY_TMP_DIR/relay.ini $RELAY_INI_DIR
- name: Dump version
run: php --ri relay | grep -i version |
@tillkruss We can let it fail, with the error that x86_64 is not supported on macOS. |
@shivammathur I've search for everything I can think of but I'm not sure how to do this correctly, can you point me at an extension on how to fail the install with a message? |
@tillkruss I have added that in 6f15379 |
Much appreciated! |
name: ⚙ Improvement
about: Want to improve something
labels: enhancement
A Pull Request should be associated with a Discussion.
Related discussion: #1010
Description
This PR [briefly explain what it does]
npm run format
before the commit.npm run lint
before the commit.npm run release
before the commit.npm test
returns with no unit test errors and all code covered.