Skip to content

Conversation

tillkruss
Copy link
Contributor

@tillkruss tillkruss commented Dec 13, 2024

Description

This PR adds support to install Relay on PHP 8.4 and 8.5.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

@tillkruss tillkruss changed the title support 8.4 and 8.5 for relay Relay: Support PHP 8.4 and 8.5 Dec 13, 2024
@shivammathur shivammathur merged commit 7ee42db into shivammathur:develop Dec 13, 2024
6 checks passed
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (19ba822) to head (cdbb899).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #892   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          806       806           
  Branches       291       291           
=========================================
  Hits           806       806           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tillkruss tillkruss deleted the patch-2 branch December 13, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants