Skip to content

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Jun 3, 2025

name: ⚙ Improvement
about: Update Phive configuration
labels: enhancement


Description

Latest Phive (0.16.0) claims to require PHP 8.0 or later[1]. While I have not found any issues running it under PHP 7.4, it might be better to stick with Phive 0.15.3 for PHP 7.3/7.4.

[1] https://github.com/phar-io/phive/releases/tag/0.16.0

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

I'm not sure whether this change needs a dedicated discussion, but if you deem it sensible, I'll open one.

Latest Phive (0.16.0) claims to require PHP 8.0 or later[1].  While I
have not found any issues running it under PHP 7.4, it might be better
to stick with Phive 0.15.3 for PHP 7.3/7.4.

[1] <https://github.com/phar-io/phive/releases/tag/0.16.0>
@shivammathur shivammathur merged commit 6ba658a into shivammathur:develop Jun 3, 2025
64 checks passed
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b595b41) to head (c954e9c).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #957   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          815       818    +3     
  Branches       294       295    +1     
=========================================
+ Hits           815       818    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmb69 cmb69 deleted the cmb/phive-0.15.3 branch June 3, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants