-
-
Notifications
You must be signed in to change notification settings - Fork 395
Add support for shipmonk/name-collision-detector tool #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for shipmonk/name-collision-detector tool #973
Conversation
Co-authored-by: shivammathur <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #973 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 805 805
Branches 284 285 +1
=========================================
Hits 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add an entry in the tools section in the README as well similar to how other tools are documented.
Co-authored-by: shivammathur <[email protected]>
Added name-collision-detector to the README tools section as requested. The tool is now documented alongside other supported tools in the tools list. (commit a3845d8) |
Co-authored-by: shivammathur <[email protected]>
This PR adds support for the
shipmonk/name-collision-detector
tool to the setup-php action, following the existing pattern for other ShipMonk composer-based tools.What is name-collision-detector?
The
shipmonk/name-collision-detector
is a fast PHP tool that detects duplicate class, interface, enum, trait, constant, or function names within the same namespace. It helps prevent ambiguous class resolution issues that can cause hard-to-debug problems in PHP projects.Usage
After this PR, users can include the tool in their GitHub Actions workflows:
Changes Made
Added tool configuration in
src/configs/tools.json
:composer
(installed via Composer)shipmonk/name-collision-detector
scoped
(for proper isolation)Added comprehensive test coverage in
__tests__/tools.test.ts
:Generated expected output: The tool will be installed using
add_composer_tool name-collision-detector name-collision-detector shipmonk/ scoped
Benefits
collision-detector.json
configuration filecomposer-dependency-analyser
Testing
This addition enhances the PHP development experience by providing an easy way to catch name collision issues early in the development cycle.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.