Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 17, 2025

This PR adds support for the roave/backward-compatibility-check tool, a popular Composer package used to detect backward compatibility breaks in PHP libraries.

Changes Made

1. Tool Configuration

  • Added roave-backward-compatibility-check to src/configs/tools.json as a scoped Composer tool
  • Configured with proper alias to ensure correct tool naming in generated scripts

2. Documentation Updates

  • Added the tool to the tools list in README.md
  • Added repository link at the bottom of README.md following the existing pattern

3. Test Coverage

  • Added comprehensive test coverage for the new tool in __tests__/tools.test.ts
  • Tests cover Darwin, Linux, and Windows platforms
  • All existing tests continue to pass

4. Bug Fix

  • Fixed the addPackage function to use data['tool'] instead of parts[1] for proper tool naming, ensuring aliases work correctly

Usage

Users can now install roave/backward-compatibility-check using:

- name: Setup PHP with roave/backward-compatibility-check
  uses: shivammathur/setup-php@v2
  with:
    php-version: '8.1'
    tools: roave-backward-compatibility-check

The tool will be installed as a scoped Composer dependency and be available for use in CI workflows to check for backward compatibility breaks.

Testing

  • All existing tests pass with 100% code coverage
  • New tests verify the tool is correctly configured across all supported platforms
  • The tool follows the same patterns as other Composer-based tools in the project

Closes: Request for adding roave/backward-compatibility-check tool support


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] Create a PR adding roave/backward-compatibility-check similar to previous PRs for adding other composer based tools, include tests, entry in the tools section for the tool and a link to the repo at the bottom of the README like other tools. Add support for roave/backward-compatibility-check tool Jul 17, 2025
@Copilot Copilot AI requested a review from shivammathur July 17, 2025 08:37
Copilot finished work on behalf of shivammathur July 17, 2025 08:37
Copy link
Owner

@shivammathur shivammathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the review

…ool to backward-compatibility-check

Co-authored-by: shivammathur <[email protected]>
@Copilot Copilot AI requested a review from shivammathur July 17, 2025 08:55
Copilot finished work on behalf of shivammathur July 17, 2025 08:55
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (011ab6e) to head (f9fbb51).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #974   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          805       805           
  Branches       284       285    +1     
=========================================
  Hits           805       805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shivammathur shivammathur changed the base branch from main to develop July 17, 2025 09:03
Copy link
Owner

@shivammathur shivammathur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase it on develop, I changed the base to develop

Copy link
Contributor Author

Copilot AI commented Jul 17, 2025

Rebase it on develop, I changed the base to develop

Branch has been successfully rebased on develop in commit 1c12093. All changes are preserved and tests are passing.

@Copilot Copilot AI requested a review from shivammathur July 17, 2025 09:25
Copilot finished work on behalf of shivammathur July 17, 2025 09:25
@shivammathur shivammathur marked this pull request as ready for review July 17, 2025 09:29
@shivammathur shivammathur merged commit 725b407 into develop Jul 17, 2025
@shivammathur shivammathur deleted the copilot/fix-d6851e4e-e860-4989-8c53-4391e7116ea7 branch July 17, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants