-
-
Notifications
You must be signed in to change notification settings - Fork 395
Add support for mago tool as custom package #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mago tool as custom package #975
Conversation
Co-authored-by: shivammathur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except these minor changes
…isplay Co-authored-by: shivammathur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick, also add mago in the tools section of README and the link to mago repo at the bottom of the README. Add them in correct order alphabetically.
…add to README Co-authored-by: shivammathur <[email protected]>
Added mago to README tools section and link at bottom in commit 5581e61 - both added in correct alphabetical order after |
Co-authored-by: shivammathur <[email protected]>
Co-authored-by: shivammathur <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 805 805
Branches 285 285
=========================================
Hits 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds support for the mago tool, which is a comprehensive toolchain for PHP that helps developers write better code with features like code analysis, linting, automated fixes, formatting, and semantic checks.
Changes Made
1. Tool Configuration
mago
tosrc/configs/tools.json
as a custom package with:carthage-software/mago
https://github.com
""
(no "v" prefix as specified in requirements)2. Shell Script Implementation (
src/scripts/tools/mago.sh
)unknown-linux-gnu
for Linux,apple-darwin
for macOS)/usr/local/bin/mago
3. PowerShell Script Implementation (
src/scripts/tools/mago.ps1
)4. Test Coverage
latest
version and specific version (e.g.,0.26.1
)Usage
Users can now install mago using:
Or with a specific version:
Implementation Details
The implementation follows the existing pattern used by other custom packages like
protoc
, with key differences:All tests pass and the tool is fully functional across all supported platforms.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
carthage.software
curl -s https://carthage.software/mago.sh
(dns block)https://api.github.com/repos/carthage-software/mago/releases/latest
curl -s REDACTED
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.