fix: Pass the correct extensions#57
Open
njakobsen wants to merge 1 commit into
Open
Conversation
It looks like `extensions` was created with the intention to pass the extensions to the Column constructor. However, a second variable `extentions` was also created to store the extensions identified in the definition args. Unfortunately this second variable was not used, despite containing the desired extensions, and the original variable, which contained the unfiltered definition, was passed to the constructor. Instead, the variable containing the unfiltered args has been removed, and the typo in the variable containing the filtered list has been corrected. This results in the correct extensions being passed to the Column constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
extensionswas created with the intention to pass the extensions to the Column constructor. However, a second variableextentionswas also created to store the extensions identified in the definition args. Unfortunately this second variable was not used, despite containing the desired extensions, and the original variable, which contained the unfiltered definition, was passed to the constructor.Instead, the variable containing the unfiltered args has been removed, and the typo in the variable containing the filtered list has been corrected. This results in the correct extensions being passed to the Column constructor.