Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/native date inputs #250

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 7, 2024

Closes #249

Replace date inputs from react-datepicker with native input[type="date"] and input[type="datetime-locale"].

@acelaya acelaya force-pushed the feature/native-date-inputs branch 2 times, most recently from dd7fc88 to e179d4c Compare February 8, 2024 08:02
@acelaya acelaya force-pushed the feature/native-date-inputs branch from e179d4c to 759f8f2 Compare February 8, 2024 08:33
@acelaya acelaya marked this pull request as ready for review February 8, 2024 19:24
@acelaya acelaya force-pushed the feature/native-date-inputs branch from 85d68b0 to 18835b2 Compare February 8, 2024 19:26
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (3fc5730) 83.55% compared to head (18835b2) 83.49%.

Files Patch % Lines
src/short-urls/ShortUrlForm.tsx 73.17% 0 Missing and 11 partials ⚠️
src/utils/dates/DateInput.tsx 71.05% 3 Missing and 8 partials ⚠️
src/utils/dates/DateRangeRow.tsx 90.90% 0 Missing and 1 partial ⚠️
src/utils/dates/LabelledDateInput.tsx 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   83.55%   83.49%   -0.07%     
==========================================
  Files         161      161              
  Lines        9438     9458      +20     
  Branches     1275     1279       +4     
==========================================
+ Hits         7886     7897      +11     
- Misses        303      306       +3     
- Partials     1249     1255       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit cfe966a into shlinkio:main Feb 8, 2024
5 of 7 checks passed
@acelaya acelaya deleted the feature/native-date-inputs branch February 8, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using native date inputs instead of react-datepicker
1 participant