Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to manage redirect rules for a short URL #284

Merged
merged 16 commits into from
Mar 17, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 9, 2024

Closes #271

Add a new section to manage redirect rules for a short URL, which is available only when consuming Shlink >=4.0.0

Improvements for future PRs:

  • Order rules via drag'n'drop.
  • Order rules with animation when using buttons.
  • Show a hint of what short URLs have already configured rules in the short URL list.
redirect-rules-ui-2024-03-17_10.18.03.mp4

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 85.95166% with 93 lines in your changes are missing coverage. Please review.

Project coverage is 84.95%. Comparing base (a208485) to head (bc20ba6).
Report is 19 commits behind head on main.

Files Patch % Lines
src/redirect-rules/helpers/RedirectRuleModal.tsx 84.98% 0 Missing and 38 partials ⚠️
src/redirect-rules/ShortUrlRedirectRules.tsx 81.48% 5 Missing and 25 partials ⚠️
...edirect-rules/reducers/setShortUrlRedirectRules.ts 85.71% 0 Missing and 8 partials ⚠️
...c/redirect-rules/reducers/shortUrlRedirectRules.ts 82.05% 0 Missing and 7 partials ⚠️
src/redirect-rules/helpers/RedirectRuleCard.tsx 94.68% 0 Missing and 5 partials ⚠️
src/short-urls/helpers/ShortUrlsRowMenu.tsx 80.00% 0 Missing and 2 partials ⚠️
src/short-urls/helpers/hooks.ts 66.66% 0 Missing and 2 partials ⚠️
src/Main.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   83.52%   84.95%   +1.42%     
==========================================
  Files         161      159       -2     
  Lines        9435     9898     +463     
  Branches     1287     1365      +78     
==========================================
+ Hits         7881     8409     +528     
+ Misses        293      150     -143     
- Partials     1261     1339      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/redirect-rules branch from 248f3bf to aafdd1a Compare March 16, 2024 11:05
@acelaya acelaya force-pushed the feature/redirect-rules branch from aafdd1a to 6bceaa5 Compare March 16, 2024 11:12
@acelaya acelaya marked this pull request as ready for review March 17, 2024 09:15
@acelaya acelaya merged commit eb1708a into shlinkio:main Mar 17, 2024
7 checks passed
@acelaya acelaya deleted the feature/redirect-rules branch March 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support editing redirect rules for any short URL
1 participant